-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Myalgomate Pivot Point Add new Type #1
base: main
Are you sure you want to change the base?
Conversation
You’ll have to retarget to the DaveSkender repo main branch instead of your own main branch. Just edit above. |
Is this an entirely new type or is it supposed to just add the 3rd and 4th level to the standard type? |
Both the calculations are different internal static TPivotPoint GetPivotPointStandard(
internal static TPivotPoint GetPivotChartIQ(
|
We can add it to standard itself |
Pivot point = (H + L + C) / 3 |
Yah, if I’m interpreting right, you only need to add this to the standard type: S3 = pp - 2 * (high - low),
R3 = pp + 2 * (high - low) I’ll take a closer look tomorrow. |
Also, you can close/delete this PR and use the other pointing to the base repo one instead. DaveSkender#671 |
Also, check your sources, Wikipedia is saying for standard type: R3 = H + 2×(P − L) = R1 + (H − L)
S3 = L − 2×(H − P) = S1 − (H − L) |
Okay Agreed, we can modify the standard itself. Let me know once its done |
BY SUBMITTING A PULL REQUEST AND CHANGES TO THIS REPOSITORY YOU ARE ACKNOWLEDGING AND AGREE TO THE TERMS IN BOTH THE DEVELOPER CERTIFICATE OF ORIGIN AND THE APACHE 2.0 LICENSE.
PLEASE REMOVE EXPLANATORY TEXT AND UNNEEDED SECTIONS BEFORE CREATING PULL REQUEST. CREATE A DRAFT PULL REQUEST IF YOU INTEND TO ADD MORE COMMITS. REMOVE DRAFT STATUS AND REQUEST REVIEW FROM
DaveSkender
WHEN YOU ARE READY TO COMMIT CHANGES.Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation, context, and sources of information or recipes.
Fixes #
Checklist